Skip to content

fix(config): allow LogLevel to work with isolatedModules and update all warns and errors to respect logLevel #30350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 16, 2025
Merged

fix(config): allow LogLevel to work with isolatedModules and update all warns and errors to respect logLevel #30350

merged 20 commits into from
Apr 16, 2025

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Apr 10, 2025 •
edited
Loading

Issue number: internal

What is the current behavior?

  • LogLevel throws error Error: Cannot access ambient const enums when 'isolatedModules' is enabled
  • Several existing console warns and errors are not calling the function that respects the logLevel config

What is the new behavior?

  • Remove const from the enum to work with isolatedModules
  • Update console.warns to printIonWarning
  • Update console.errors to printIonError

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.5.5-dev.11744729748.174bf7e0

@vercel
Copy link

vercel bot commented Apr 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 4:23pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Apr 10, 2025
@github-actions github-actions bot removed package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Apr 14, 2025
@brandyscarney brandyscarney marked this pull request as ready for review April 15, 2025 16:45
@brandyscarney brandyscarney requested a review from a team as a code owner April 15, 2025 16:45
@brandyscarney brandyscarney requested a review from thetaPC April 15, 2025 16:45
thetaPC
thetaPC approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ShaneK
ShaneK approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@brandyscarney brandyscarney added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit d52fca0 Apr 16, 2025
50 checks passed
@brandyscarney brandyscarney deleted the FW-6442 branch April 16, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneK ShaneK ShaneK approved these changes

@thetaPC thetaPC thetaPC approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandyscarney @ShaneK @thetaPC