-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(tokens): fix usage on components and review scss architecture #30368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 39 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
863fc6e
fix accordion tokens
BenOsodrac 8263909
fix avatar tokens
BenOsodrac e16104a
fix avatar typography
BenOsodrac 32e9822
fix backdrop tokens & architecture
BenOsodrac bee20eb
fix button tokens architecture
BenOsodrac 63f71c6
fix lint
BenOsodrac 93afcbe
fix card import
BenOsodrac f6e1a15
fix chip tokens
BenOsodrac 0b754b0
fix chip line-height
BenOsodrac c2faa10
gix input-password-toggle tokens
BenOsodrac 73f68e7
fix item tokens
BenOsodrac b1d8de7
fix item-option tokens
BenOsodrac 0685641
fix item-options tokens
BenOsodrac 7844bda
fix list tokens
BenOsodrac bd74ac1
fix list-header tokens
BenOsodrac 9c7886d
fix modal tokens
BenOsodrac 4b0da4e
fix progress-bar tokens
BenOsodrac 7f87d79
fix radio tokens
BenOsodrac 2f398ef
fix range tokens
BenOsodrac 7473309
fix ripple-effect tokens
BenOsodrac 78f6d3c
fix searchbar tokens
BenOsodrac a22f034
fix spinner tokens
BenOsodrac 7d6c1c8
fix tab-button tokens
BenOsodrac 50ecdb3
fix toast tokens
BenOsodrac 668caf1
fix toggle tokens
BenOsodrac ee5c1c4
fix badge tokens
BenOsodrac 01fe718
fix input tokens
BenOsodrac 3201a19
fix select tokens
BenOsodrac c9d0c69
fix textarea tokens
BenOsodrac 482d4a0
chore(): add updated snapshots
Ionitron 73bd0ff
fix input warning disabled
BenOsodrac f169494
fix progress buffle color
BenOsodrac 61e0ffe
fix spinner tests
BenOsodrac 1a6458c
fix textarea tests
BenOsodrac bac6af1
fix lint
BenOsodrac 529eb33
chore(): add updated snapshots
Ionitron 3d28e67
fix textarea label
BenOsodrac 1522e0f
chore(): add updated snapshots
Ionitron df841bf
chore(): add updated snapshots
Ionitron b0a6a7c
fix badge typography tokens
BenOsodrac 458c570
remove input native vars file
BenOsodrac 8e1d4b8
fix button typography
BenOsodrac 716d621
remove chip font-family
BenOsodrac 58efa3f
remove item font-family
BenOsodrac 38a1b7b
fix tab-bar shape test
BenOsodrac eb3951e
fix lint
BenOsodrac 0202754
chore(): add updated snapshots
Ionitron d74af2f
revert button typography changes
BenOsodrac 9d90892
chore(): add updated snapshots
Ionitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| @use "../../themes/ionic/ionic.globals.scss" as globals; | ||
| @import "./backdrop"; | ||
| @use "./backdrop.common"; | ||
|
|
||
| :host { | ||
| background-color: rgba(globals.$ion-primitives-base-black-rgb, 0.7); | ||
|
|
||
| z-index: 2; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
8 changes: 5 additions & 3 deletions
8
core/src/components/button/button.vars.scss → .../components/backdrop/backdrop.native.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| @import "./backdrop.common"; | ||
| @import "../../themes/native/native.globals"; | ||
|
|
||
| // Button | ||
| // Backdrop | ||
| // -------------------------------------------------- | ||
|
|
||
| /// @prop - Badge padding inside button | ||
| $button-badge-padding: 2px; | ||
| :host { | ||
| z-index: $z-index-backdrop; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.