-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(item): emit click event once when clicking padded space on item and emit correct element #30373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only had two comments, but I they're more just for my own confirmation than change requests
|
Super cool! :D |
Issue number: resolves #29758 resolves #29761
What is the current behavior?
When an
ion-itemhas a click event listener, the following issues occur:ion-checkbox,ion-toggle,ion-radio,ion-textarea,ion-input) triggers the click event twice.ion-inputandion-textarea, clicking their native inputs reports the wrong element as the event target.native-wrapperofion-inputemits a separate click event with an incorrect target element.What is the new behavior?
firstInteractive.click()in Item for all interactives (no longer excludes input/textarea).ion-input/ion-textareainstead of the native input elements.native-wrappertriggering its own click event when clicking on its padding.Does this introduce a breaking change?
Other information
Dev build:
8.5.6-dev.11745613928.16440384Previews: