feat(badge): remove xxsmall, xsmall and xlarge sizes #30392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OS-giulianasilva
changed the title
ShaneK
requested changes
May 6, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Generally, we're moving towards a better way of doing defaults that makes it easier to change in the future if we need to. I've left a few change requests in specific areas, but avatar is a really good example of this paradigm in use for size.
ShaneK
approved these changes
May 7, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks really good, great work!
Member
|
Weirdly your screenshot tests seem to have failed even though you updated them after pushing 🤔 I guess maybe try updating them again? If nothing changes then run your tests again? Very odd! |
BenOsodrac
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The badge presents the
xxsmall,xsmall, andxlarge. The user experience design expects only thesmallandmediumsizes for badges with content (number or icon), andsmall,medium, andlargesizes for empty badges.What is the new behavior?
smallandmediumsizes must be adjusted to the new requirements for badges with content.largesize is only available for empty badges.Does this introduce a breaking change?