Skip to content

fix(progress-bar, spinner): update colors for ionic theme #30418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025
Merged

fix(progress-bar, spinner): update colors for ionic theme #30418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea599ff
- Fix Progress-Bar Ionic Colors;
JoaoFerreira-FrontEnd May 21, 2025
fcc3e84
Merge branch 'next' into ROU-11917
JoaoFerreira-FrontEnd May 21, 2025
a00cc6f
- clean selector;
JoaoFerreira-FrontEnd May 23, 2025
6683f18
- lint.fix
JoaoFerreira-FrontEnd May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions core/src/components/progress-bar/progress-bar.common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,6 @@
}
}

:host(.ion-color) {
.progress,
.progress-indeterminate {
background: #{current-color(base)};
}
}

// Progress Bar: Animation Keyframes
// ------------------------------------------------------------------------
// Source: https://github.com/material-components/material-components-web/blob/master/packages/mdc-linear-progress/_keyframes.scss
Expand Down
7 changes: 7 additions & 0 deletions core/src/components/progress-bar/progress-bar.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@
// Progress Bar: Color
// ------------------------------------------------------------------------

:host(.ion-color) {
.progress,
.progress-indeterminate {
background: #{globals.current-color(base)};
}
}

:host(.ion-color) .buffer-circles {
background-image: radial-gradient(
ellipse at center,
Expand Down
7 changes: 7 additions & 0 deletions core/src/components/progress-bar/progress-bar.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@
// Progress Bar: Color
// ------------------------------------------------------------------------

:host(.ion-color) {
.progress,
.progress-indeterminate {
background: #{current-color(base)};
}
}

:host(.ion-color) .buffer-circles {
background-image: radial-gradient(
ellipse at center,
Expand Down
4 changes: 4 additions & 0 deletions core/src/components/spinner/spinner.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
height: globals.$ion-scale-700;
}

:host(.ion-color-medium) {
color: #{globals.ion-color(medium, contrast, $subtle: true)};
Copy link
Member

@ShaneK ShaneK May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm still against this because really we shouldn't be changing the behavior of a color like this. Ideally, colors would be consistently applied, saying I want color medium here should be color medium, not the subtle color you're going for. I think you're trying to get the default color that's applied when no color is applied - the value set in the host - which is why you're doing this here, but I don't think this is the right thing to do since the user is saying they want the medium color and you're actively not giving them a medium color but the subtle form of the contrast of the medium color.

I think what you should do is handle this in the widget, just check if the medium color was passed and don't set the color value if it was if that's what you're going for, because I think this will create unexpected results in the long term.

However, I will approve it still because it's more-or-less a nit at this point and I think we're going to have to review colors at some point in the future where this will end up being changed anyway. So either way you want to go I'll approve, I just don't think this is the right way, personally.

Copy link
Contributor Author

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your point/concern. I'll share it with the Design team and PO

}

// Spinner: lines / lines-small / lines-sharp / lines-sharp-small
// --------------------------------------------------

Expand Down
Loading