fix(toolbar): allow slot to size to content to account for images #30508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
approved these changes
Jun 25, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Solid improvement! Also thanks for fixing my typos 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Images do not appear because their width is calculated as
0when determining the widths of slotted content.What is the new behavior?
Sets the
flex-basisvariable toautoif the slot contains an img to allow it to calculate the width using the image's intrinsic width.Does this introduce a breaking change?
Other information
Dev build:
8.6.2-dev.11750780384.13227a56