Skip to content

chore(angular): upgrade test apps to latest #30517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 30, 2025
Merged

chore(angular): upgrade test apps to latest #30517

merged 13 commits into from
Jun 30, 2025

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jun 27, 2025 •
edited
Loading

Issue number: N/A

What is the current behavior?

Angular base has outdated files, which has lead to many duplicated files within the versioned apps. Base files should always be the latest.

What is the new behavior?

  • Updated base files to the latest
  • Removed duplicate files from the versioned apps since base will provide them
  • Added files to the older versioned apps since they no longer align with the latest files with base

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@vercel
Copy link

vercel bot commented Jun 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 11:07pm

@github-actions github-actions bot added the package: angular @ionic/angular package label Jun 27, 2025
thetaPC
thetaPC commented Jun 27, 2025
View reviewed changes
packages/angular/test/apps/ng16/angular.json
Copy link
Contributor Author

@thetaPC thetaPC Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was considered a rename when I manually deleted the file from ng19 and added a new file within ng16. The same applies for the other renames.

Copy link
Member

@ShaneK ShaneK Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git doesn't have a way to identify when a file was deleted or renamed, so if a file is removed and another one is added and they're similar enough it just considers it a rename. If a file just disappears then it considers it deleted. Sometimes it has false positives like this haha

@thetaPC thetaPC marked this pull request as ready for review June 27, 2025 22:59
@thetaPC thetaPC requested a review from a team as a code owner June 27, 2025 22:59
@thetaPC thetaPC requested a review from brandyscarney June 27, 2025 22:59
brandyscarney
brandyscarney approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code, tested all versions of the test app. Looks good! 👍

@brandyscarney brandyscarney requested a review from ShaneK June 30, 2025 15:36
@brandyscarney brandyscarney added this pull request to the merge queue Jun 30, 2025
@brandyscarney brandyscarney removed this pull request from the merge queue due to a manual request Jun 30, 2025
ShaneK
ShaneK approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid addition, great work! 🎉

packages/angular/test/apps/ng16/angular.json
Copy link
Member

@ShaneK ShaneK Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git doesn't have a way to identify when a file was deleted or renamed, so if a file is removed and another one is added and they're similar enough it just considers it a rename. If a file just disappears then it considers it deleted. Sometimes it has false positives like this haha

@brandyscarney brandyscarney added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 7b9f306 Jun 30, 2025
51 checks passed
@brandyscarney brandyscarney deleted the angular-test-apps branch June 30, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneK ShaneK ShaneK approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees

No one assigned

Labels

package: angular @ionic/angular package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thetaPC @ShaneK @brandyscarney