Skip to content

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jun 27, 2025

Blocks #30513


The latest Playwright update in #30513 exposed an issue in Safari where dynamically setting the RTL direction on the document no longer works. This causes the Breadcrumbs screenshots to fail because they are not flipping the arrow icon.

This PR converts the Breadcrumbs e2e tests to use setContent which works properly with RTL and also breaks the tests up more so they aren't one giant screenshot.

  • The Basic test has been updated to focus mainly on the default breadcrumbs without any colors or collapsed breadcrumbs.
  • The Collapsed test has been updated to remove some of the duplicated examples and ported over one from the basic test.
  • The Color test was added which focuses on setting different colors on the Breadcrumbs / Breadcrumb and moves this out of the basic test.

@vercel
Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 2:55pm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these could probably be removed as screenshots and just check the count on the visible breadcrumbs. LMK if you think there are too many screenshots here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of these could just be programmatic tests, but also they're probably fine as visual regression tests like this. I'm fine either way. I do like this much more granular approach to visually testing them though!

@brandyscarney brandyscarney marked this pull request as ready for review June 30, 2025 15:18
@brandyscarney brandyscarney requested a review from a team as a code owner June 30, 2025 15:18
@brandyscarney brandyscarney requested a review from ShaneK June 30, 2025 15:18
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a lot of screenshots, but all the tests make sense to me and I really prefer this change. Great job!

@brandyscarney brandyscarney added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit ac81383 Jun 30, 2025
52 checks passed
@brandyscarney brandyscarney deleted the bc/test-breadcrumbs branch June 30, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants