Skip to content

feat(toggle): add press state for ionic theme #30550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2025
Merged

feat(toggle): add press state for ionic theme #30550

merged 4 commits into from
Jul 17, 2025

Conversation

@OS-martacarlos
Copy link

@OS-martacarlos OS-martacarlos commented Jul 15, 2025 •
edited
Loading

Issue number: internal

What is the current behavior?

  • The current toggle, using the ionic theme, is not following the design for pressed state, as well as the default background color for unchecked toggles

What is the new behavior?

For the ionic theme:

  • Changes unselected toggle background color to follow the new style: `ion-primitives-neutral-500
  • Changes the toggle background color for pressed states: ion-bg-primary-base-press and ion-bg-neutral-base-press, for checked and unchecked toggles, respectively
  • updates the toggle snapshots accordingly

Does this introduce a breaking change?

  • Yes
  • No

@OS-martacarlos OS-martacarlos self-assigned this Jul 15, 2025
@OS-martacarlos OS-martacarlos added the package: core @ionic/core package label Jul 15, 2025
@vercel
Copy link

vercel bot commented Jul 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 2:31pm

@OS-martacarlos OS-martacarlos marked this pull request as ready for review July 15, 2025 14:44
@OS-martacarlos OS-martacarlos requested a review from a team as a code owner July 15, 2025 14:44
@OS-martacarlos OS-martacarlos merged commit 34fd510 into next Jul 17, 2025
59 checks passed
@OS-martacarlos OS-martacarlos deleted the ROU-12074 branch July 17, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneK ShaneK ShaneK approved these changes

@OS-pedrolourenco OS-pedrolourenco OS-pedrolourenco approved these changes

@brandyscarney brandyscarney Awaiting requested review from brandyscarney brandyscarney is a code owner automatically assigned from ionic-team/framework

Assignees

@OS-martacarlos OS-martacarlos

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OS-martacarlos @ShaneK @OS-pedrolourenco @Ionitron