Skip to content

Conversation

@JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Aug 5, 2025

Issue number: internal


What is the new behavior?

  • improve tokens usage;

Does this introduce a breaking change?

  • Yes
  • No

Other information

shapes

@vercel
Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 4:30pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 5, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd marked this pull request as ready for review August 5, 2025 15:02
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner August 5, 2025 15:02
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because it looks right, but you may consider screenshot tests for visual regression prevention

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 560a791 into next Aug 7, 2025
49 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-12131 branch August 7, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants