-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(input): improve error text accessibility #30635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ec83531
fix(input): add aria-live attributes to error text
ShaneK e358cab
Merge branch 'main' of github.com:ionic-team/ionic-framework into ion…
ShaneK a7295b4
fix(input): making validation reading work more consistently across b…
ShaneK fc05815
fix(lint): fixing lint in test files
ShaneK f1bb778
Merge branch 'main' of github.com:ionic-team/ionic-framework into ion…
ShaneK 9ebada9
App validation tests
ShaneK 1baf39e
fix(input): improve validation state reactivity
ShaneK 5760856
fix(input): fixing input validation accessibility for template-driven…
ShaneK 85b8cbf
fix(input): cleanup on input validation
ShaneK 1d0c191
fix(cleanup): removing file
ShaneK 65dd166
Restoring tests
ShaneK a9ff301
Merge branch 'main' of github.com:ionic-team/ionic-framework into ion…
ShaneK 65867ce
refactor(input): removing debug code
ShaneK df8fa7d
refactor(input): removing angular-specific code from core
ShaneK 0180454
fix(lint): fixing lint in core
ShaneK 7fc8cbc
Update packages/angular/test/base/src/app/standalone/validation/input…
ShaneK 2db2b1f
Update core/src/components/input/test/validation/index.html
ShaneK 7926f08
Update core/src/components/textarea/test/validation/index.html
ShaneK 1493bf7
refactor(tests, input): doing cleanup across input and tests
ShaneK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.