feat(themes): add support for modular themes and custom themes #30651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Aug 28, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
This is looking really good, I tested it and everything seems to be working well. Great work!
brandyscarney
added a commit
that referenced
this pull request
Sep 25, 2025
Issue number: internal --------- ## What is the new behavior? - Moves `openURL` out of the `theme` utils because it makes more sense in `helpers` - Adds support for the default `default.tokens.ts` design tokens file - Adds support for custom theme set globally and on a component ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Requires additional changes in order to test. --------- Co-authored-by: Brandy Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
openURLout of thethemeutils because it makes more sense inhelpersdefault.tokens.tsdesign tokens fileDoes this introduce a breaking change?
Other information
Requires additional changes in order to test.