-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(col): modernizing Grid component #30658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
b348896
Changes to support new version of columns
rugoncalves dab2be3
Supporting new properties and removing old ones
rugoncalves 72a271b
Adding default gap
rugoncalves 95431df
Moving the CSS variable to the host
rugoncalves 3842d64
Updating breaking changes list
rugoncalves e1a0648
Code adjustments
rugoncalves 39a9b1e
Small fixes
rugoncalves 53fa8dd
Re-adding the properties push and pull
rugoncalves 83522f8
Deprecating properties
rugoncalves 11166d3
Warning when push or pull properties are used
rugoncalves b59627f
Removing default value of columns
rugoncalves 30a0ce6
Fix lint problems
rugoncalves bcc1268
Fixing more lint problems
rugoncalves 13c35b0
Merge branch 'next' into ROU-11882
rugoncalves 06af570
Fixing the css classes
rugoncalves dc4856f
style: lint
brandyscarney dd32ece
Update text of breaking change
rugoncalves 7b7c524
Setting good defaults
rugoncalves 25865ee
Changing class names to avoid clash
rugoncalves 306eea9
Removing unwanted css
rugoncalves e411078
Updating tests to not use pull and push
rugoncalves f8a83e9
Adding new page with deprecated tests for pull & push
rugoncalves 35903c0
chore(): add updated snapshots
Ionitron 00f8abd
Running lint
rugoncalves d47c1bd
Updating migration path
rugoncalves 3649dec
Adding max-width to the columns
rugoncalves 98f2630
Fixing lint
rugoncalves 2200674
Revert "chore(): add updated snapshots"
rugoncalves 1b707c0
chore(): add updated snapshots
Ionitron 1a5f74b
Merge branch 'next' into ROU-11882
rugoncalves 09fcdc7
Updating text to reflect the test
rugoncalves d407ed2
Update BREAKING.md
rugoncalves 1a9e6af
Update BREAKING.md
rugoncalves bd81597
Update BREAKING.md
rugoncalves 47ba9bb
Code review feedback
rugoncalves d213920
Merge branch 'ROU-11882' of https://github.com/ionic-team/ionic-frame…
rugoncalves cba75d6
Revert "chore(): add updated snapshots"
rugoncalves c7f5633
chore(): add updated snapshots
Ionitron fdfb0f3
Adding a comment to clarify the variable value [skip-ci]
rugoncalves 98e977c
Merge branch 'ROU-11882' of https://github.com/ionic-team/ionic-frame…
rugoncalves 8909df2
Improving comment and running lint
rugoncalves 122a7d7
Removing variable initialization
rugoncalves 8334750
Adding overflow auto to columns
rugoncalves 706efb3
Updating api.txt
rugoncalves 10f3d85
chore(): add updated snapshots
Ionitron 1bdebf1
Changing font-size in test pages
rugoncalves 4c2b555
Revert "chore(): add updated snapshots"
rugoncalves d881cf5
chore(): add updated snapshots
Ionitron 17e5a37
Changing the font-size for a given sample
rugoncalves 9cd243a
chore(): add updated snapshots
Ionitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.