- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.4k
 
feat(tokens): update tokens usage to reflect UI architecture #30678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           The latest updates on your projects. Learn more about Vercel for GitHub. 
  | 
    
This reverts commit f33a194.
This reverts commit 579cf44.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly questions here clarifying the variables being used, but it looks good overall! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small suggestion to tie in with the global theming but since this will likely be re-worked with the modular work it is not a blocker. 👍
Issue number: internal
What is the new behavior?
This pull request updates the color and background variables across many Ionic component styles to use new design system tokens, improving consistency and maintainability. It also temporarily skips several visual regression tests for the
datetimecomponent due to a known issue (FW-6769).Design System Token Migration:
--colorand--backgroundvariables in many components (e.g.,card,card-title,list-header,item,segment,radio,select,textarea,input,checkbox,chip,datetime,item-options,searchbar) to use the newglobals.$ion-text-defaultandglobals.$ion-bg-surface-defaulttokens instead of older primitives. This change ensures consistent theming and easier future maintenance. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]Test Suite Maintenance:
There're some snapshots updates that seem to have no visible differences, so I would say its ok to accept the new ones.
Does this introduce a breaking change?