Skip to content

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Oct 13, 2025

Issue number: internal


What is the new behavior?

This pull request makes a minor update to the generateColorUtilityClasses function to improve how CSS custom property values are interpolated in the generated class definitions.

  • In core/scripts/tokens/utils.mjs, the function now wraps the SCSS variable reference for the custom property value in #{...} to ensure proper interpolation when generating the CSS class.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels Oct 13, 2025
@vercel
Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Oct 13, 2025 0:52am

@BenOsodrac BenOsodrac changed the title ROU-12273: fix color classes generation from tokens fix(tokens): fix color classes generation from tokens Oct 13, 2025
@BenOsodrac BenOsodrac changed the title fix(tokens): fix color classes generation from tokens fix(tokens): color classes generation from tokens Oct 13, 2025
@BenOsodrac BenOsodrac marked this pull request as ready for review October 13, 2025 12:47
@BenOsodrac BenOsodrac requested a review from a team as a code owner October 13, 2025 12:47
@brandyscarney brandyscarney merged commit 635edaf into next Oct 13, 2025
143 of 149 checks passed
@brandyscarney brandyscarney deleted the ROU-12273 branch October 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants