- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.4k
fix(select): remove item focus style when there are no selected items only at ionic mode #30750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            12 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      bfdf1ab
              
                fix(Item): fix item-native style to ionic theme
              
              
                joselrio b01c591
              
                fix(Item): run lint
              
              
                joselrio 09eb85b
              
                fix(Item): prevent default focus style when there is any selected option
              
              
                joselrio b87a914
              
                chore(): add updated snapshots
              
              
                Ionitron cf52df7
              
                fix(select): update into the correct token
              
              
                joselrio ca039d6
              
                fix(Item): split nested sass standards
              
              
                joselrio e2d565e
              
                Merge branch 'next' into ROU-12235
              
              
                joselrio 633c2ed
              
                fix(Item): make changes only when under context of select modal
              
              
                joselrio 975f544
              
                chore(): add updated snapshots
              
              
                Ionitron 6a989c3
              
                chore(): add updated snapshots
              
              
                Ionitron 1da3928
              
                Update core/src/components/item/item.ionic.scss
              
              
                joselrio afb828f
              
                fix(item): revert flaky updated screenshots
              
              
                joselrio File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
        
          
  
    
      
          Binary file modified
          
            BIN
              
                -1.02 KB
                  (97%)
              
          
        
  ...em.e2e.ts-snapshots/item-states-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
  
    
      
          Binary file modified
          
            BIN
              
                +1.93 KB
                  (100%)
              
          
        
  ...m.e2e.ts-snapshots/item-states-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
  
    
      
          Binary file modified
          
            BIN
              
                +492 Bytes
                  (100%)
              
          
        
  ...em.e2e.ts-snapshots/item-states-diff-ionic-md-ltr-light-Mobile-Safari-linux.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.