-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(select): add missing filled type styles #30755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
564fa3f
fix(select): update to the expected color
joselrio 4f29944
fix(select): added missing background color to solid fill
joselrio 9dedfdf
fix(select): lint
joselrio 8be50c0
chore(): add updated snapshots
Ionitron 478d18b
Update core/src/components/select/select.ionic.scss
joselrio 001f4ab
Update core/src/components/select/select.ionic.scss
joselrio 0d0d39c
Merge branch 'next' into ROU-12161
joselrio 8de58d8
fix(select): update colors based on if there's a selected value
joselrio 0c2616d
chore(): add updated snapshots
Ionitron f10c1c4
chore(): add updated snapshots
Ionitron a41be43
fix(select): revert flaky screenshots
joselrio f1f201d
fix(select): revert flaky screenshot
joselrio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-205 Bytes
(92%)
...2e.ts-snapshots/select-outline-color-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6 Bytes
(100%)
...e.ts-snapshots/select-outline-color-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7 Bytes
(100%)
...2e.ts-snapshots/select-outline-color-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-100 Bytes
(96%)
....e2e.ts-snapshots/select-custom-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
...e2e.ts-snapshots/select-custom-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png
joselrio marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+30 Bytes
(100%)
....e2e.ts-snapshots/select-custom-diff-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-168 Bytes
(95%)
...s-snapshots/select-custom-parts-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-86 Bytes
(98%)
...-snapshots/select-custom-parts-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...s-snapshots/select-custom-parts-diff-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-148 Bytes
(93%)
...e2e.ts-snapshots/select-fill-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-32 Bytes
(99%)
...2e.ts-snapshots/select-fill-outline-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-59 Bytes
(98%)
...e2e.ts-snapshots/select-fill-outline-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-182 Bytes
(92%)
...e2e.ts-snapshots/select-fill-outline-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-28 Bytes
(99%)
...2e.ts-snapshots/select-fill-outline-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7 Bytes
(100%)
...e2e.ts-snapshots/select-fill-outline-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-155 Bytes
(92%)
...ts/select-fill-shaped-outline-custom-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-22 Bytes
(99%)
...s/select-fill-shaped-outline-custom-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...ts/select-fill-shaped-outline-custom-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-135 Bytes
(93%)
...ts/select-fill-shaped-outline-custom-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15 Bytes
(99%)
...s/select-fill-shaped-outline-custom-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-24 Bytes
(99%)
...ts/select-fill-shaped-outline-custom-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-601 Bytes
(92%)
...hots/select-outline-custom-highlight-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-47 Bytes
(100%)
...ots/select-outline-custom-highlight-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
...hots/select-outline-custom-highlight-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-401 Bytes
(93%)
...2e.ts-snapshots/select-outline-focus-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-29 Bytes
(100%)
...e.ts-snapshots/select-outline-focus-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-27 Bytes
(100%)
...2e.ts-snapshots/select-outline-focus-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-432 Bytes
(92%)
....ts-snapshots/select-outline-invalid-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...ts-snapshots/select-outline-invalid-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
....ts-snapshots/select-outline-invalid-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-422 Bytes
(93%)
...2e.ts-snapshots/select-outline-valid-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-20 Bytes
(100%)
...e.ts-snapshots/select-outline-valid-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-11 Bytes
(100%)
...2e.ts-snapshots/select-outline-valid-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-103 Bytes
(93%)
...-snapshots/select-inset-list-no-fill-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-24 Bytes
(99%)
...snapshots/select-inset-list-no-fill-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-45 Bytes
(98%)
...-snapshots/select-inset-list-no-fill-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-37 Bytes
(98%)
...snapshots/select-item-flex-container-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-10 Bytes
(100%)
...napshots/select-item-flex-container-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-48 Bytes
(98%)
...snapshots/select-item-flex-container-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-46 Bytes
(97%)
...e2e.ts-snapshots/select-list-no-fill-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...2e.ts-snapshots/select-list-no-fill-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-8 Bytes
(100%)
...e2e.ts-snapshots/select-list-no-fill-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-46 Bytes
(98%)
...shots/select-label-stacked-long-text-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-43 Bytes
(99%)
...hots/select-label-stacked-long-text-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-18 Bytes
(100%)
...shots/select-label-stacked-long-text-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-63 Bytes
(97%)
...shots/select-label-stacked-long-text-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-42 Bytes
(99%)
...hots/select-label-stacked-long-text-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5 Bytes
(100%)
...shots/select-label-stacked-long-text-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-152 Bytes
(92%)
...snapshots/select-label-stacked-value-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-49 Bytes
(98%)
...napshots/select-label-stacked-value-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-9 Bytes
(100%)
...snapshots/select-label-stacked-value-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-134 Bytes
(93%)
...snapshots/select-label-stacked-value-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-36 Bytes
(99%)
...napshots/select-label-stacked-value-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+17 Bytes
(100%)
...snapshots/select-label-stacked-value-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-126 Bytes
(93%)
...elect-shape-rectangular-fill-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-33 Bytes
(99%)
...lect-shape-rectangular-fill-outline-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+15 Bytes
(100%)
...elect-shape-rectangular-fill-outline-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-179 Bytes
(93%)
...hots/select-shape-round-fill-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-13 Bytes
(100%)
...ots/select-shape-round-fill-outline-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
...hots/select-shape-round-fill-outline-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-151 Bytes
(93%)
...shots/select-shape-soft-fill-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(99%)
...hots/select-shape-soft-fill-outline-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+4 Bytes
(100%)
...shots/select-shape-soft-fill-outline-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-173 Bytes
(93%)
...t.e2e.ts-snapshots/select-size-large-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-33 Bytes
(99%)
....e2e.ts-snapshots/select-size-large-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
...t.e2e.ts-snapshots/select-size-large-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-82 Bytes
(96%)
...pshots/select-size-large-unset-label-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-27 Bytes
(99%)
...shots/select-size-large-unset-label-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...pshots/select-size-large-unset-label-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-179 Bytes
(93%)
....e2e.ts-snapshots/select-size-medium-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-13 Bytes
(100%)
...e2e.ts-snapshots/select-size-medium-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
....e2e.ts-snapshots/select-size-medium-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-80 Bytes
(96%)
...shots/select-size-medium-unset-label-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-13 Bytes
(99%)
...hots/select-size-medium-unset-label-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+26 Bytes
(100%)
...shots/select-size-medium-unset-label-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-172 Bytes
(93%)
...t.e2e.ts-snapshots/select-size-small-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-18 Bytes
(99%)
....e2e.ts-snapshots/select-size-small-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...t.e2e.ts-snapshots/select-size-small-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-67 Bytes
(97%)
...pshots/select-size-small-unset-label-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-20 Bytes
(99%)
...shots/select-size-small-unset-label-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...pshots/select-size-small-unset-label-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-232 Bytes
(89%)
...select.e2e.ts-snapshots/select-value-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-18 Bytes
(99%)
...elect.e2e.ts-snapshots/select-value-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+0 Bytes
(100%)
...select.e2e.ts-snapshots/select-value-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+323 Bytes
(100%)
...ar.e2e.ts-snapshots/tab-bar-default-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.