Skip to content

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 1, 2025

The workflow permissions update did not work due to it being nested in a workflow that only had read permissions.

You can see a failing run here (scroll down to annotations): 19828029833

Invalid workflow file: .github/workflows/release-orchestrator.yml#L71
The workflow is not valid. .github/workflows/release-orchestrator.yml (Line: 71, Col: 3): Error calling workflow 'ionic-team/ionic-framework/.github/workflows/release.yml@b4e540decc484bd22eb84484a8eb94f19b1790c1'. The nested job 'finalize-release' is requesting 'contents: write', but is only allowed 'contents: read'. .github/workflows/release-orchestrator.yml (Line: 71, Col: 3): Error calling workflow 'ionic-team/ionic-framework/.github/workflows/release.yml@b4e540decc484bd22eb84484a8eb94f19b1790c1'. The nested job 'update-package-lock' is requesting 'contents: write', but is only allowed 'contents: read'.

This updates the parent workflow to have write permissions. You can see a passing run here: 19828895682

@brandyscarney brandyscarney marked this pull request as ready for review December 1, 2025 16:14
@brandyscarney brandyscarney requested a review from a team as a code owner December 1, 2025 16:14
@vercel
Copy link

vercel bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Dec 1, 2025 4:14pm

@brandyscarney brandyscarney added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit c65b76e Dec 1, 2025
64 checks passed
@brandyscarney brandyscarney deleted the chore/workflows-release branch December 1, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants