feat(radio-group): remove radio-group-wrapper and convert to shadow DOM#30835
feat(radio-group): remove radio-group-wrapper and convert to shadow DOM#30835OS-pedrolourenco merged 11 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-pedrolourenco
changed the title
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looking good, just a few requests!
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
|
|
||
| ion-radio-group { | ||
| // Prevents additional pixels from being rendered on top | ||
| vertical-align: top; |
There was a problem hiding this comment.
This became unnecessary by introducing display: block
| .radio-group-top { | ||
| @include globals.typography(globals.$ion-body-sm-medium); | ||
|
|
||
| margin-bottom: globals.$ion-space-400; |
There was a problem hiding this comment.
This margin was being overridden on the OS side, thus this style makes no sense to exist here. Will remove the override as well.
brandyscarney
changed the title
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
LGTM! Great work! 🚀
Can we add a section in the breaking changes document that radio group has been converted to shadow: https://github.com/ionic-team/ionic-framework/blob/next/BREAKING.md
Here's an example of when we converted modal in v6: https://github.com/ionic-team/ionic-framework/blob/next/BREAKING_ARCHIVE/v6.md#modal
2 participants
Issue number: internal
What is the current behavior?
The radio-group's wrapper div is responsible for several issues that have been reported, specially due to making it so that radio elements are not direct children of radio-groups. Now it is also causing problems on the OutSystems side.
What is the new behavior?
The solution involved:
Does this introduce a breaking change?
Other information