Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Dec 8, 2025

Issue number: N/A


What is the current behavior?

high-contrast and high-contrast-dark palettes were not working when requested through a URL query or hash for a test page. This was due to the match not accepting hyphens so it would only save high which is not a valid palette.

What is the new behavior?

  • Updated match to accept hyphens
  • Added an error if an invalid palette is provided
  • Added a palette fallback if an invalid palette is provided
  • Added a class check for high contrast and high contrast dark

Does this introduce a breaking change?

  • Yes
  • No

Other information

How to test:

  1. Verify that ?palette=high-contrast, ?palette=high-contrast-dark, #palette=high-contrast, and #palette=high-contrast-dark render correctly (I recommend using button basic page)

@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Dec 8, 2025 7:41pm

@github-actions github-actions bot added the package: core @ionic/core package label Dec 8, 2025
@thetaPC thetaPC marked this pull request as ready for review December 8, 2025 17:14
@thetaPC thetaPC requested a review from a team as a code owner December 8, 2025 17:14
@thetaPC thetaPC requested a review from brandyscarney December 8, 2025 17:14
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue with the console warn message but other than that it looks good!

@thetaPC thetaPC added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit 3129565 Dec 8, 2025
51 checks passed
@thetaPC thetaPC deleted the scripts branch December 8, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants