Skip to content

fix(tab-bar): prevent keyboard controller memory leak on rapid mount/unmount #30906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShaneK wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(tab-bar): prevent keyboard controller memory leak on rapid mount/unmount #30906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b441d
fix(tab-bar): prevent keyboard controller memory leak on rapid mount/…
ShaneK Jan 5, 2026
6ea7cef
fix(tab-bar): prevent keyboard controller memory leak on rapid mount/…
ShaneK Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion core/src/components/tab-bar/tab-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import type { TabBarChangedEventDetail } from './tab-bar-interface';
})
export class TabBar implements ComponentInterface {
private keyboardCtrl: KeyboardController | null = null;
private keyboardCtrlPromise: Promise<KeyboardController> | null = null;
private didLoad = false;

@Element() el!: HTMLElement;
Expand Down Expand Up @@ -88,7 +89,7 @@ export class TabBar implements ComponentInterface {
}

async connectedCallback() {
this.keyboardCtrl = await createKeyboardController(async (keyboardOpen, waitForResize) => {
const promise = createKeyboardController(async (keyboardOpen, waitForResize) => {
/**
* If the keyboard is hiding, then we need to wait
* for the webview to resize. Otherwise, the tab bar
Expand All @@ -100,11 +101,32 @@ export class TabBar implements ComponentInterface {

this.keyboardVisible = keyboardOpen; // trigger re-render by updating state
});
this.keyboardCtrlPromise = promise;

const keyboardCtrl = await promise;

/**
* Only assign if this is still the current promise.
* Otherwise, a new connectedCallback has started or
* disconnectedCallback was called, so destroy this instance.
*/
if (this.keyboardCtrlPromise === promise) {
this.keyboardCtrl = keyboardCtrl;
this.keyboardCtrlPromise = null;
} else {
keyboardCtrl.destroy();
}
}

disconnectedCallback() {
if (this.keyboardCtrlPromise) {
this.keyboardCtrlPromise.then((ctrl) => ctrl.destroy());
this.keyboardCtrlPromise = null;
}

if (this.keyboardCtrl) {
this.keyboardCtrl.destroy();
this.keyboardCtrl = null;
}
}

Expand Down
Loading