Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30561
What is the current behavior?
When an
ion-selectwithinterface="popover"orinterface="modal"is opened with the keyboard, pressing Enter on a focused option doesn't commit the value or dismiss the overlay. Only Space works. TheonKeyUphandlers inselect-popover.tsxandselect-modal.tsxonly checked for' ', despite the comment claiming Enter was supported, andion-radio-group's arrow-key handler never committed the focused value on Enter the way native<select>does.What is the new behavior?
Pressing Enter on a focused option in the popover or modal interface now commits that option as the select's value and dismisses the overlay, matching Space and native
<select>behavior.radio-group.tsxgains an Enter branch inside its select-interface arrow-key handler that setsvalueto the focused radio and emitsionChangewhen it differs from the previous value.select-popover.tsxandselect-modal.tsxtrack theonKeyDowntarget soonKeyUponly dismisses when the Enter press started on the same option. That guard stops a held Enter on the triggeringion-selectfrom re-firing inside the just-opened overlay and auto-dismissing it. The!ev.repeatcheck on keydown covers the same case for the radio-group commit.Does this introduce a breaking change?
Other information
The keydown/keyup target-matching pattern is the same trick the browser uses to avoid firing a click when keydown and keyup happen on different elements. It's needed here because Enter on the
ion-selecttrigger opens the overlay on keydown, and without the guard the corresponding keyup (now inside the overlay) would immediately commit and dismiss.Preview page: