This repository was archived by the owner on Sep 15, 2021. It is now read-only.
Open
Conversation
Contributor
|
three issues:
|
gortok
suggested changes
Sep 21, 2016
Contributor
gortok
left a comment
gortok
left a comment
There was a problem hiding this comment.
You made the change to the dist/* folder insetad of the src/plugins/.js. That means that change won't be there next build. The dist folder is just a build artifact. If you want the change to stick around it has to go in the actual src/plugins/.js file.
Please target the dev-next instead of master with your PR.
Please omit any dist/* files from your commit; it gives future merging a headache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added abort method for cordova-plugin-file-transfer