Skip to content

fix: secondary camera #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: secondary camera #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 44 additions & 7 deletions src/components/camera/camera.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class CameraPWA {

@Prop({ context: 'isServer' }) private isServer: boolean;

@Prop() facingMode: string = 'user';
Copy link
Contributor Author

@mtsmachado8 mtsmachado8 Nov 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default shoud be environment. not sure why @capacitor/core is not setting the correct one BTW. Even when i set Rear its not working
image

Copy link
Contributor Author

@mtsmachado8 mtsmachado8 Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Prop() facingMode: string = 'environment';

@Prop() handlePhoto: (photo: Blob) => void;
@Prop() handleNoDeviceError: (e?: any) => void;
Expand Down Expand Up @@ -46,6 +46,8 @@ export class CameraPWA {
imageCapture: any;
// Video element when using ImageCapture native API
videoElement: HTMLVideoElement;
// The list of connected devices with videoinput type
videoDevices: Array<MediaDeviceInfo>;
// Canvas element for ImageCapture polyfill
canvasElement: HTMLCanvasElement;
// Whether the device has multiple cameras (front/back)
Expand Down Expand Up @@ -90,10 +92,10 @@ export class CameraPWA {
async queryDevices() {
try {
const devices = await navigator.mediaDevices.enumerateDevices();
const videoDevices = devices.filter(d => d.kind == 'videoinput')
this.videoDevices = devices.filter(d => d.kind == 'videoinput')

this.hasCamera = !!videoDevices.length;
this.hasMultipleCameras = videoDevices.length > 1;
this.hasCamera = !!this.videoDevices.length;
this.hasMultipleCameras = this.videoDevices.length > 1;
} catch(e) {
this.deviceError = e;
}
Expand All @@ -104,16 +106,49 @@ export class CameraPWA {
constraints = this.defaultConstraints;
}

navigator.mediaDevices.getUserMedia({
video: true,
audio: false,
...constraints
})
.then(stream => this.initStream(stream))
.catch(e => {
switch (e.name) {
// Usually happens when camera is not available or manufacturer didn't implement the default one correctly
case 'NotReadableError':
this.initSecondaryCamera(constraints)
break
default:
this.deviceError = e;
this.handleNoDeviceError && this.handleNoDeviceError(e);
}
})
}

async initSecondaryCamera(constraints?: MediaStreamConstraints) {
const devicesFacingTheCorrectSide = this.videoDevices
.filter(device => {
if(this.facingMode === 'environment'){
return device.label.includes('facing back')
} else {
return device.label.includes('facing front')
}
})

try {
const secondaryId = devicesFacingTheCorrectSide[devicesFacingTheCorrectSide.length -1].deviceId
const stream = await navigator.mediaDevices.getUserMedia({
video: true,
audio: false,
...constraints
...constraints,
video: {
deviceId: secondaryId
}
});

this.initStream(stream);
} catch(e) {
} catch (e) {
this.deviceError = e;
console.log(`Error initing secondary camera ${e}`)
this.handleNoDeviceError && this.handleNoDeviceError(e);
}
}
Expand Down Expand Up @@ -260,12 +295,14 @@ export class CameraPWA {
}

if (facingMode === 'environment') {
this.facingMode = 'user';
this.initCamera({
video: {
facingMode: 'user'
}
});
} else {
this.facingMode = 'environment';
this.initCamera({
video: {
facingMode: 'environment'
Expand Down