Use ilogger colorized prettyprint and analyzer uri#180
Open
smoothdeveloper wants to merge 5 commits intoionide:mainfrom
Open
Use ilogger colorized prettyprint and analyzer uri#180smoothdeveloper wants to merge 5 commits intoionide:mainfrom
smoothdeveloper wants to merge 5 commits intoionide:mainfrom
Conversation
dawedawe
requested changes
Dec 18, 2023
…back to the Microsoft.Extensions.Logging branch.
… touch in my PR AFAIR)
de69ac4 to
b1fce92
Compare
Author
|
after rebasing all seems consistent (including what fantomas formatted, versus comment), let see if this gets green. |
Contributor
|
While I like the change, I don't really want to take the risk for the release of the current week. |
Author
|
No hurries, no worries :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redo #174/#176 on top of @dawedawe #175 (this PR should only show my commit(s) once #175 is merged I think).
I'm not sure how to check the mode that is not using the command line, but I assume; the integration into MSBuild, so please let me know if adjustments are needed there and how I should invoke it in a custom project.
This does two things:
Regarding how I initially did it and now, I see we use "vanilla .NET string formatting" instead of interpolation or fsharp formatting specifyier which enforces there are matching arguments.
I was wondering if this was important to use this less safe way due to relying on the logging infrastructure changes done in #175 or we can reconsider going through F# format specifiers without losing on the logging infrastructure integration?