Closed
Conversation
MangelMaxime
commented
Dec 16, 2023
Comment on lines
-247
to
+261
| let date = pDate .>> skipRestOfLine true | ||
| let date = pDate | ||
| let yanked = opt spaces1 >>. pYanked |
Author
There was a problem hiding this comment.
I was not able to keep the .>> skipRestOfLine true for some reason it was making the tests fails.
Contributor
|
If a code repository is not set up to use auto-formatting, you should not use a formatter in your PR! This would have saved you a lot of effort, to be honest 😸 |
Author
|
I agree problem was that it was setup to use it on save and saw it too late. I will re-send the PR without the formatting change. |
56074a5 to
4e72d71
Compare
Author
|
I am closing because I think going in the direction from #17 makes more sense. Out sourcing the parser work would make it easier to maintain Ionide.KeepAChangelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
copilot:summary
copilot:poem
copilot:emoji
WHY
HOW
copilot:walkthrough
Sorry for the big PR, the auto formatting didn't help on that here 🙈
I think copilot for PR is not available anymore so I will write a good old description myself ahah.
Releasesfrom a list of tuple to using a list of record has we are starting to have a lot of properties[YANKED]tag #26I was not able to test the
Ionide.KeepAChangelog.Tasksproject because when packing it there seems to be missing somedll.I think this is something that was discovered with the last release already