Check for C# extension dependencies at runtime#2088
Merged
baronfel merged 2 commits intoionide:mainfrom May 30, 2025
Merged
Conversation
baronfel
approved these changes
May 29, 2025
Contributor
baronfel
left a comment
There was a problem hiding this comment.
This seems like an easy substitution - really the only thing we use the C# extension for today is debugging related, so another way this could be handled instead of blocking is to
- do capabilities-based detection (probing for the 'coreclr' debug type)
- in the debugging code, if debugging isn't available throw a message/notification to the user directing them to the extensions panel for the C# extension that's present in their environment
ButA1
reviewed
May 30, 2025
Contributor
|
Thanks for this - we'll get a release out later today US time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We should not have a hard dependency on
ms-dotnettools.csharpsince that makes it impossible to use Ionide with forks os VScode e.g Cursor. This PR does the check at runtime instead adding recommended extensions to the Extension Pack tab instead.Fixes #2087
How