fix: Allow control plane endpoint updates with empty location (#255)#266
Merged
jriedel-ionos merged 1 commit intorelease-0.5from Jan 15, 2025
Merged
fix: Allow control plane endpoint updates with empty location (#255)#266jriedel-ionos merged 1 commit intorelease-0.5from
jriedel-ionos merged 1 commit intorelease-0.5from
Conversation
**What is the purpose of this pull request/Why do we need it?** This validation is blocking successful reconciliation of kamaji resources under certain circumstances. I should've noticed while testing it the first time, but I think my test data was limited to a single scenario. **Issue #, if available:** **Description of changes:** Remove validation blocking updates to control plane endpoint when location is not set. **Special notes for your reviewer:** I tested this by updating the CRD manually and seeing reconciliation succeed. **Checklist:** - [ ] Documentation updated - [ ] Unit Tests added - [ ] E2E Tests added - [x] Includes [emojis](https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#kubebuilder-project-versioning)
jriedel-ionos
requested review from
gfariasalves-ionos,
mcbenjemaa,
piepmatz and
wikkyk
as code owners
|
piepmatz
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #255 for release v0.5.1