Open
Conversation
tuunit
changed the title
tuunit
force-pushed
the
flatcar-support
branch
from
9f4a485 to
baf26f8
Compare
tuunit
requested review from
gfariasalves-ionos,
jriedel-ionos,
mcbenjemaa,
piepmatz and
wikkyk
as code owners
mcbenjemaa
reviewed
Jan 27, 2025
| renderedData := s.renderUserData(ms, string(bootstrapData)) | ||
| renderedData, err := s.enrichUserData(ms, bootstrapFormat, string(bootstrapData)) | ||
| if err != nil { | ||
| return fmt.Errorf("enriching user data: %w", err) |
Member
There was a problem hiding this comment.
We can improve user visibility here.
by setting a condition and throwing a warning event.
Member
Author
There was a problem hiding this comment.
What exactly do you mean by setting a condition?
Member
There was a problem hiding this comment.
something like:
conditions.MarkFalse(
ms.IonosMachine,
infrav1.MachineProvisionedCondition,
infrav1.RenderBootstrapDataReason,
clusterv1.ConditionSeverityInfo, "",
)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request/Why do we need it?
Introduce experimental support for flatcar by adding injection support for ignition user-data.
Issue #, if available:
Implements #268
Description of changes:
Special notes for your reviewer:
Checklist: