Skip to content

Comments

feat: Add fail-fast behavior to Ginkgo in test-e2e#359

Merged
wikkyk merged 1 commit intoionos-cloud:mainfrom
MCMXCIII:make-e2e-fail-early-194
Dec 10, 2024
Merged

feat: Add fail-fast behavior to Ginkgo in test-e2e#359
wikkyk merged 1 commit intoionos-cloud:mainfrom
MCMXCIII:make-e2e-fail-early-194

Conversation

@MCMXCIII
Copy link
Contributor

@MCMXCIII MCMXCIII commented Dec 10, 2024

in regards to the follwing issue:
https://github.com/ionos-cloud/cluster-api-provider-proxmox/issues/194

What was changed: Describe the specific change:

Added --fail-fast to the Ginkgo command in the test-e2e target of the Makefile.
Ensures the e2e test suite halts immediately upon encountering a failure.

Why the change was made:

Saves compute resources and time by stopping further tests when a failure is detected.

Further information about the --fail-fast flag can be found here: https://onsi.github.io/ginkgo/

@github-actions
Copy link

🚀 e2e tests run

We add labels to the PRs to control the e2e test runs by running specific tests and skipping some test contexts,
please follow this guide:

Label Behaviour
none Run Generic tests
e2e/none skip all e2e tests (documentation etc) - overrides all e2e/* labels Do not run any tests (overrides all e2e/ flags)
e2e/flatcar run Flatcar e2e tests Add Flatcar tests to the run

ℹ️ Ask a Member to add the requested labels if you don't have enough permissions.

@sonarqubecloud
Copy link

@wikkyk
Copy link
Collaborator

wikkyk commented Dec 10, 2024

test and e2e pass was discarded by rebase, merging.

@wikkyk wikkyk merged commit f3ec6b0 into ionos-cloud:main Dec 10, 2024
1 check failed
@wikkyk
Copy link
Collaborator

wikkyk commented Dec 10, 2024

Thanks!

@MCMXCIII MCMXCIII deleted the make-e2e-fail-early-194 branch December 10, 2024 17:35
@MCMXCIII MCMXCIII mentioned this pull request Dec 10, 2024
rybnico pushed a commit to rybnico/cluster-api-provider-proxmox that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants