Introduce API v1alpha2 #531
Conversation
TestsPlease note that running unit and e2e tests requires manual approval from a team member. e2e testsWe use labels to control which e2e tests contexts are run:
ℹ️ Ask a team member to add the requested labels if you don't have enough permissions. |
|
I split the compat table in two and removed redundant information to make them a bit more readable. The old table was getting long. |
|
Should get https://github.com/kubernetes-sigs/kube-api-linter set up for this. |
|
Needs porting to CAPI 1.11/v1beta2. |
You can finish your rebase and changes, and then we can migrate CAPI v1beta2 and conversation webhooks to a separate PR. I can take this. |
|
I agree. Though we should minimise the amount of time that |
| ignition "github.com/flatcar/ignition/config/v2_3" | ||
| ignitionTypes "github.com/flatcar/ignition/config/v2_3/types" | ||
| "github.com/pkg/errors" | ||
| "inet.af/netaddr" |
There was a problem hiding this comment.
https://pkg.go.dev/inet.af/netaddr is deprecated
There was a problem hiding this comment.
let's create a follow-up issue for this.
There was a problem hiding this comment.
yeah, I also don't like github.com/pkg/errors
|
rebased on v0.7.5 |
|
Issue #, if available:
#293
Description of changes:
I forward-ported 1d76694 to main. I ported all the new features to v1alpha2.
This is still very much WIP, it doesn't actually work, tests fail, etc. However, that's the bulk of the large changes done and we'll be able to work more incrementally now.
The conversion webook is missing.
We'll need to keep rebasing this on main if necessary until it's ready to merge.
Testing performed:
It compiles.
SomeMany Go tests succeed,manysome Go tests fail.Nothing else was tried yet.