Skip to content

enhancement: add omitempty to optional fileconfig fields #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avirtopeanu-ionos merged 2 commits into from
Jun 20, 2025
Merged

enhancement: add omitempty to optional fileconfig fields #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a74d02
enhancement: add omitempty to optional fileconfig fields
avirtopeanu-ionos Jun 20, 2025
b969c09
undo: rm omitempty from token
avirtopeanu-ionos Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shared/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ type ClientOptions struct {

// Credentials are the credentials that will be used for authentication
type Credentials struct {
Username string `yaml:"username"`
Password string `yaml:"password"`
Username string `yaml:"username,omitempty"`
Password string `yaml:"password,omitempty"`
Token string `yaml:"token"`
}

Expand Down
2 changes: 1 addition & 1 deletion shared/fileconfiguration/fileconfiguration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ type Endpoint struct {
// Products that do not have a location and will override the endpoint that is used globally:
// cloud, objectstoragemanagement, kafka, dns, mongo, psql, dataplatform, creg, autoscaling, apigateway
// Products that have location-based endpoints: logging, monitoring, containerregistry, vpn, inmemorydb, nfs, objectstorage, mariadb
Location string `yaml:"location"`
Location string `yaml:"location,omitempty"`
Name string `yaml:"name"`
SkipTLSVerify bool `yaml:"skipTlsVerify"`
CertificateAuthData string `yaml:"certificateAuthData,omitempty"`
Expand Down
Loading