Skip to content

poc for fileconfiguration failover #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristiGuranIonos merged 15 commits into from
Mar 6, 2026
Merged

poc for fileconfiguration failover #55

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
50098a7
poc for fileconfiguration failover
cristiGuranIonos Feb 24, 2026
e5bdbb3
add options struct,
cristiGuranIonos Feb 25, 2026
66094f5
add backoff options to failover config, did not handle 429 status cod…
glimberea Feb 25, 2026
2048af9
fail on correct errors, fix tests, remove unused function
cristiGuranIonos Feb 26, 2026
7581c72
add more comments to document behaviour, fix dns test to expect error
glimberea Feb 26, 2026
e5852bc
feat: move callAPI logic to shared package, keep callAPI as wrapper (…
glimberea Feb 27, 2026
ba74617
fix all issues caught by sonarqube (#60)
glimberea Mar 2, 2026
f89cf0e
add e2e tests (#59)
cristiGuranIonos Mar 2, 2026
e235960
Pass only failover and servers and stricter error checks (#61)
cristiGuranIonos Mar 5, 2026
bce3fa0
Update shared/failover/failover_roundtripper.go
cristiGuranIonos Mar 5, 2026
a35ce4e
Update shared/fileconfiguration/fileconfiguration.go
cristiGuranIonos Mar 5, 2026
cbe7076
Update shared/retry/retry.go
cristiGuranIonos Mar 5, 2026
56dd938
fix: remove compute test from shared
cristiGuranIonos Mar 5, 2026
a4d07d6
fix: log attempt
cristiGuranIonos Mar 5, 2026
7dd68bc
fix: remove replace
cristiGuranIonos Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 4 additions & 111 deletions products/compute/client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions products/compute/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ require (
golang.org/x/oauth2 v0.30.0
)

replace github.com/ionos-cloud/sdk-go-bundle/shared => ../../shared

require (
github.com/aws/aws-sdk-go v1.55.7 // indirect
github.com/cenkalti/backoff/v5 v5.0.3 // indirect
github.com/jmespath/go-jmespath v0.4.0 // indirect
)

replace github.com/ionos-cloud/sdk-go-bundle/shared => ../../shared
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate replace github.com/ionos-cloud/sdk-go-bundle/shared => ../../shared: this file declares it twice, which will make go mod tidy fail. Remove one of the duplicate replace directives.

Suggested change
replace github.com/ionos-cloud/sdk-go-bundle/shared => ../../shared

Copilot uses AI. Check for mistakes.
26 changes: 11 additions & 15 deletions products/compute/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,23 @@
cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
github.com/aws/aws-sdk-go v1.55.7 h1:UJrkFq7es5CShfBwlWAC8DA077vp8PyVbQd3lqLiztE=
github.com/aws/aws-sdk-go v1.55.7/go.mod h1:eRwEWoyTWFMVYVQzKMNHWP5/RV4xIUGMQfXQHfHkpNU=
github.com/cenkalti/backoff/v5 v5.0.3 h1:ZN+IMa753KfX5hd8vVaMixjnqRZ3y8CuJKRKj1xcsSM=
github.com/cenkalti/backoff/v5 v5.0.3/go.mod h1:rkhZdG3JZukswDf7f0cwqPNk4K0sa+F97BxZthm/crw=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/golang/protobuf v1.2.0 h1:P3YflyNX/ehuJFLhxviNdFxQPkGK5cDcApsge1SqnvM=
github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
github.com/ionos-cloud/sdk-go-bundle/shared v0.1.6 h1:mN5ZC7dTGD0SpEmbGJwa9QBStF0DvV1O9tp2nakLCo0=
github.com/ionos-cloud/sdk-go-bundle/shared v0.1.6/go.mod h1:E5MtZ15l6L5wn7JmjL5ccSvGcX5Dk7G8s882X1ZH6dM=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/jmespath/go-jmespath v0.4.0 h1:BEgLn5cpjn8UN1mAw4NjwDrS35OdebyEtFe+9YPoQUg=
github.com/jmespath/go-jmespath v0.4.0/go.mod h1:T8mJZnbsbmF+m6zOOFylbeCJqk5+pHWvzYPziyZiYoo=
github.com/jmespath/go-jmespath/internal/testify v1.5.1 h1:shLQSRRSCCPj3f2gpwzGwWFoC7ycTf1rcQZHOlsJ6N8=
github.com/jmespath/go-jmespath/internal/testify v1.5.1/go.mod h1:L3OGu8Wl2/fWfCI6z80xFu9LTZmf1ZRjMHUOPmWr69U=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
golang.org/x/net v0.0.0-20190108225652-1e06a53dbb7e h1:bRhVy7zSSasaqNksaRZiA5EEI+Ei4I1nO5Jh72wfHlg=
golang.org/x/net v0.0.0-20190108225652-1e06a53dbb7e/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45 h1:SVwTIAaPC2U/AvvLNZ2a7OVsmBpC8L5BlwK1whH3hm0=
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
golang.org/x/oauth2 v0.30.0 h1:dnDm7JmhM45NNpd8FDDeLhK6FwqbOf4MLCM9zb1BOHI=
golang.org/x/oauth2 v0.30.0/go.mod h1:B++QgG3ZKulg6sRPGD/mqlHQs5rB3Ml9erfeDY7xKlU=
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4 h1:YUO/7uOKsKeq9UokNS62b8FYywz3ker1l1vDZRCRefw=
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
google.golang.org/appengine v1.4.0 h1:/wp5JvzpHIxhs/dumFmF7BXTf3Z+dd4uXta4kVyO508=
google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10=
gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
6 changes: 3 additions & 3 deletions shared/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const (
IonosObjectStorageRegion = "IONOS_OBJECT_STORAGE_REGION"
DefaultIonosServerUrl = "https://api.ionos.com/"

defaultMaxRetries = 3
DefaultMaxRetries = 3
defaultWaitTime = time.Duration(100) * time.Millisecond
defaultMaxWaitTime = time.Duration(2000) * time.Millisecond
defaultPollInterval = 1 * time.Second
Expand Down Expand Up @@ -155,7 +155,7 @@ func NewConfiguration(username, password, token, hostUrl string) *Configuration
Username: username,
Password: password,
Token: token,
MaxRetries: defaultMaxRetries,
MaxRetries: DefaultMaxRetries,
MaxWaitTime: defaultMaxWaitTime,
PollInterval: defaultPollInterval,
WaitTime: defaultWaitTime,
Expand Down Expand Up @@ -205,7 +205,7 @@ func NewConfigurationFromOptions(clientOptions ClientOptions) *Configuration {
Username: clientOptions.Credentials.Username,
Password: clientOptions.Credentials.Password,
Token: clientOptions.Credentials.Token,
MaxRetries: defaultMaxRetries,
MaxRetries: DefaultMaxRetries,
MaxWaitTime: defaultMaxWaitTime,
WaitTime: defaultWaitTime,
Servers: ServerConfigurations{},
Expand Down
Loading
Loading