Add s3 buckets, and infra for making more #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-Lalime
approved these changes
May 21, 2024
Contributor
Michael-Lalime
left a comment
Michael-Lalime
left a comment
There was a problem hiding this comment.
This looks reasonable to me. Let's try it and modify as needed.
ZacharyWills
force-pushed
the
ZacharyWills-patch-1
branch
from
c024b13 to
aa3bb4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a variable with Org names, each of these gets a sub-key in the bucket (like a folder) and essentially when you add a new org to the list, it creates them a space, and a policy for dealing with that space. There's sub-accounts for them if we want to give them access in the future to upload or manage those bucket locations.