You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactored the code to remove the boilerplate of passing the dataset to every check method while maintaining the same functionality. The dataset is now accessible via the instance variable self.ds in all check methods.
There's no easy way to do this without breaking other potential third party checkers. Including @ocefpaf for input here. I think at some level we'll need to keep the ds for now but refer to something like self.ds within the methods, possibly using some magic in the methods to check the value of ds and include a deprecation warning once per checker run with checkers that still use the old calling convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1080
Changes:
Refactored the code to remove the boilerplate of passing the dataset to every check method while maintaining the same functionality. The dataset is now accessible via the instance variable self.ds in all check methods.