-
Notifications
You must be signed in to change notification settings - Fork 8
feat(iori): support discontinued parts #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Yesterday17
wants to merge
4
commits into
master
Choose a base branch
from
feat/discontinued-parts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| use comparable::{Changed, assert_changes}; | ||
|
|
||
| #[test] | ||
| fn test_accuracy_discontinuity() { | ||
| let data = include_bytes!("./fixtures/discontinuity/playlist.m3u8"); | ||
| let old_result = iori_hls::m3u8_rs::parse_playlist_res(data); | ||
| let new_result = iori_hls::parse::parse_playlist_res(data); | ||
|
|
||
| let old_result = old_result.expect("Old parse engine should not error"); | ||
| let new_result = new_result.expect("New parse engine should not error"); | ||
| assert_changes!(old_result, new_result, Changed::Unchanged); | ||
|
|
||
| let media_playlist = match new_result { | ||
| iori_hls::Playlist::MediaPlaylist(media_playlist) => media_playlist, | ||
| _ => panic!("Expected media playlist"), | ||
| }; | ||
| assert_eq!(media_playlist.discontinuity_sequence, 5); | ||
|
|
||
| let segments = media_playlist.segments; | ||
| assert_eq!(segments.len(), 3); | ||
| assert_eq!(segments[0].part_index, 5); | ||
| assert_eq!(segments[1].part_index, 6); | ||
| assert_eq!(segments[2].part_index, 7); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_accuracy_discontinuity_02() { | ||
| let data = include_bytes!("./fixtures/discontinuity/playlist2.m3u8"); | ||
| let old_result = iori_hls::m3u8_rs::parse_playlist_res(data); | ||
| let new_result = iori_hls::parse::parse_playlist_res(data); | ||
|
|
||
| let old_result = old_result.expect("Old parse engine should not error"); | ||
| let new_result = new_result.expect("New parse engine should not error"); | ||
| assert_changes!(old_result, new_result, Changed::Unchanged); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_accuracy_discontinuity_no_seq() { | ||
| let data = include_bytes!("./fixtures/discontinuity/no_seq.m3u8"); | ||
| let old_result = iori_hls::m3u8_rs::parse_playlist_res(data); | ||
| let new_result = iori_hls::parse::parse_playlist_res(data); | ||
|
|
||
| let old_result = old_result.expect("Old parse engine should not error"); | ||
| let new_result = new_result.expect("New parse engine should not error"); | ||
| assert_changes!(old_result, new_result, Changed::Unchanged); | ||
|
|
||
| let media_playlist = match new_result { | ||
| iori_hls::Playlist::MediaPlaylist(media_playlist) => media_playlist, | ||
| _ => panic!("Expected media playlist"), | ||
| }; | ||
| assert_eq!(media_playlist.discontinuity_sequence, 0); | ||
|
|
||
| let segments = media_playlist.segments; | ||
| assert_eq!(segments.len(), 2); | ||
| assert_eq!(segments[0].part_index, 0); | ||
| assert_eq!(segments[1].part_index, 1); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #EXTM3U | ||
| #EXT-X-TARGETDURATION:10 | ||
| #EXT-X-VERSION:3 | ||
| #EXT-X-MEDIA-SEQUENCE:0 | ||
| #EXTINF:10.0, | ||
| segment1.ts | ||
| #EXT-X-DISCONTINUITY | ||
| #EXTINF:10.0, | ||
| segment2.ts | ||
| #EXT-X-ENDLIST | ||
|
|
14 changes: 14 additions & 0 deletions
14
crates/iori-hls/tests/fixtures/discontinuity/playlist.m3u8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #EXTM3U | ||
| #EXT-X-TARGETDURATION:10 | ||
| #EXT-X-VERSION:3 | ||
| #EXT-X-MEDIA-SEQUENCE:0 | ||
| #EXT-X-DISCONTINUITY-SEQUENCE:5 | ||
| #EXTINF:10.0, | ||
| segment1.ts | ||
| #EXT-X-DISCONTINUITY | ||
| #EXTINF:10.0, | ||
| segment2.ts | ||
| #EXT-X-DISCONTINUITY | ||
| #EXTINF:10.0, | ||
| segment3.ts | ||
| #EXT-X-ENDLIST |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.