Skip to content

fix: infinite loop bug #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
itsyaasir wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: infinite loop bug #140

itsyaasir wants to merge 11 commits into from

Conversation

@itsyaasir
Copy link
Contributor

@itsyaasir itsyaasir commented Oct 15, 2025 •
edited
Loading

Description of change

Links to any relevant issues

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@itsyaasir itsyaasir self-assigned this Oct 15, 2025
@itsyaasir itsyaasir marked this pull request as ready for review October 16, 2025 10:11
@itsyaasir itsyaasir requested a review from qrayven October 16, 2025 10:11
qrayven
qrayven reviewed Oct 16, 2025
View reviewed changes
@itsyaasir
Copy link
Contributor Author

itsyaasir commented Oct 24, 2025

This is not to be merged, and since this change will require updating the contract, we have to wait until the package manager for tracking contract versions is merged into the hierarchy. Then, we can merge this in.

@itsyaasir
Merge branch 'main' into bug/validate-property-bugs
ce89bc3
@itsyaasir
fix: reorder entries in Move.history.json for consistency
85a2a26
@itsyaasir
fix: update file pattern for Move files in build workflow
bc706e7
@itsyaasir
Merge branch 'main' into bug/validate-property-bugs
2752deb
@itsyaasir
feat: add upgrade_hierarchies script and refactor HierarchiesClientRe…
751b96f 
…adOnly to track package history
@itsyaasir
feat: add package_history method to HierarchiesClient and update pack…
a0648e2 
…age version handling in HierarchiesClientReadOnly
@itsyaasir
refactor: remove unused Env import and enhance capability retrieval i…
1972d10 
…n operations

- Removed the unused `Env` import from `read_only.rs`.
- Simplified the capability retrieval logic in `operations.rs` by using type parameters in the `find_object_for_address` method.
- Added `package_history` method to `TestClient` for improved testing capabilities.
@itsyaasir
Merge branch 'main' into bug/validate-property-bugs
d50aa4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qrayven qrayven qrayven approved these changes

Assignees

@itsyaasir itsyaasir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itsyaasir @qrayven