feat: replace Argument with SDK version#10331
Open
thibault-martinez wants to merge 12 commits intodev-tools/replace-move-core-typesfrom
Open
feat: replace Argument with SDK version#10331thibault-martinez wants to merge 12 commits intodev-tools/replace-move-core-typesfrom
Argument with SDK version#10331thibault-martinez wants to merge 12 commits intodev-tools/replace-move-core-typesfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
iota-ci
added
dev-tools
| use TransactionArgument as A; | ||
| match argument { | ||
| N::GasCoin => A::GasCoin(GasCoin { dummy: None }), | ||
| N::Gas => A::GasCoin(GasCoin { dummy: None }), |
Member
Author
There was a problem hiding this comment.
I think I would actually keep it GasCoin in the SDK, opinions?
Member
Author
There was a problem hiding this comment.
It would be inconsistent with its counterpart in the monorepo still called GasCoin
Contributor
There was a problem hiding this comment.
yeah, but so are many things we are doing in the SDK
Thoralf-M
force-pushed
the
dev-tools/replace-move-core-types
branch
from
76295fc to
1101d17
Compare
thibault-martinez
force-pushed
the
dev-tools/replace-Argument
branch
from
567ace6 to
4dc5356
Compare
Contributor
|
✅ Vercel Preview Deployment is ready! |
DaughterOfMars
approved these changes
Feb 17, 2026
thibault-martinez
force-pushed
the
dev-tools/replace-move-core-types
branch
from
4909f58 to
f48b56b
Compare
thibault-martinez
force-pushed
the
dev-tools/replace-Argument
branch
from
ecf500d to
b07d8b9
Compare
muXxer
approved these changes
Feb 17, 2026
Thoralf-M
reviewed
Feb 17, 2026
Thoralf-M
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to any relevant issues
Fixes iotaledger/iota-rust-sdk#590
How the change has been tested