Skip to content

chore: Update tracing-subscriber to fix RUSTSEC-2025-0055 #9712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DaughterOfMars merged 9 commits into from
Jan 13, 2026
Merged

chore: Update tracing-subscriber to fix RUSTSEC-2025-0055 #9712

DaughterOfMars merged 9 commits into from
Jan 13, 2026

Conversation

@DaughterOfMars
Copy link
Contributor

@DaughterOfMars DaughterOfMars commented Jan 7, 2026 •
edited
Loading

Description

Updates tracing-subscriber to avoid https://rustsec.org/advisories/RUSTSEC-2025-0055

Closes #8448

@DaughterOfMars DaughterOfMars requested review from a team as code owners January 7, 2026 09:48
@vercel
Copy link

vercel bot commented Jan 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments
Project Deployment Review Updated (UTC)
apps-backend Ignored Ignored Preview Jan 13, 2026 10:59am
apps-ui-kit Ignored Ignored Preview, Comment Jan 13, 2026 10:59am
iota-evm-bridge Ignored Ignored Preview Jan 13, 2026 10:59am
iota-multisig-toolkit Ignored Ignored Preview Jan 13, 2026 10:59am
rebased-explorer Ignored Ignored Preview Jan 13, 2026 10:59am
wallet-dashboard Ignored Ignored Preview Jan 13, 2026 10:59am

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Jan 7, 2026
@DaughterOfMars DaughterOfMars requested review from a team as code owners January 7, 2026 11:44
@thibault-martinez
Copy link
Member

thibault-martinez commented Jan 7, 2026

Ci failing 😬

@thibault-martinez
Copy link
Member

thibault-martinez commented Jan 7, 2026

Ci failing 😬

Should be fixed after #9717

@DaughterOfMars
Copy link
Contributor Author

DaughterOfMars commented Jan 13, 2026

Due to this PR which was included in async-graphql 7.1.0, it is now necessary to sort the results returned in the data field of the Response struct, because they are now randomly ordered, and the tests depend on them being in a deterministic order.

@DaughterOfMars DaughterOfMars mentioned this pull request Jan 13, 2026
Closed
6 tasks
kodemartin
kodemartin reviewed Jan 13, 2026
View reviewed changes
crates/iota-graphql-rpc-client/src/response.rs Outdated
Comment on lines 65 to 66
/// Sort the response data by first the enum variant then by the types' Ord
/// implementations
Copy link
Contributor

@kodemartin kodemartin Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not very clear to me. From the impl itself it seems that we simply sort by keys in all levels of the response body. Could you elaborate or reiterate on the doc here?

Copy link
Contributor Author

@DaughterOfMars DaughterOfMars Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, you're right. I had a different impl which better matched the comment but I will simplify it now

kodemartin
kodemartin approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thibault-martinez
thibault-martinez reviewed Jan 13, 2026
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

error[unmaintained]: Bincode is unmaintained
    ┌─ /Users/thibault/iota/iota/Cargo.lock:141:1
    │
141 │ bincode 1.3.3 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
    │
    ├ ID: RUSTSEC-2025-0141
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0141
    ├ Due to a doxxing and harassment incident, the bincode team has taken the decision to cease development permanently.

Do you want to do something about it in this PR?

@thibault-martinez
Copy link
Member

thibault-martinez commented Jan 13, 2026 

error[unmaintained]: Bincode is unmaintained
    ┌─ /Users/thibault/iota/iota/Cargo.lock:141:1
    │
141 │ bincode 1.3.3 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
    │
    ├ ID: RUSTSEC-2025-0141
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0141
    ├ Due to a doxxing and harassment incident, the bincode team has taken the decision to cease development permanently.

Do you want to do something about it in this PR?

Oh you have another PR for that my bad

@DaughterOfMars DaughterOfMars merged commit c33b939 into develop Jan 13, 2026
39 checks passed
@DaughterOfMars DaughterOfMars deleted the dev-tools/fix-RUSTSEC-2025-0055 branch January 13, 2026 11:46
begonaalvarezd pushed a commit that referenced this pull request Jan 27, 2026
@DaughterOfMars @begonaalvarezd
chore: Update tracing-subscriber to fix RUSTSEC-2025-0055 (#9712)
a667631 
## Description

Updates `tracing-subscriber` to avoid
https://rustsec.org/advisories/RUSTSEC-2025-0055

Closes #8448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@kodemartin kodemartin kodemartin approved these changes

@miker83z miker83z miker83z approved these changes

@muXxer muXxer muXxer approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees

No one assigned

Labels

dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix RUSTSEC-2025-0055

8 participants

@DaughterOfMars @thibault-martinez @kodemartin @miker83z @muXxer @Thoralf-M @iota-ci