Skip to content

Conversation

@itsyaasir
Copy link
Contributor

Description of change

Links to any relevant issues

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

itsyaasir and others added 26 commits December 11, 2025 18:44
* rename `audit_trails` folder to `audit-trails-move`
* Add folders for audit-trails-rs and audit_trails_wasm
* First implementation of the permission module based on a `Permission` enum
* Unit tests for the `Permission` enum
* Renamed `AuditTrail::permissions` to `AuditTrail::roles`
* Renamed all modules and type-names from plural to singular name
  * audit_trails -> audit_trail
  * permissions -> permission
  * capabilities -> capability
Unit tests are still buggy and will be fixed with the next commit.
Rename MetaDataUpdate to MetadataUpdate

Co-authored-by: Yasir <[email protected]>
…otaledger/notarization into feat/audit-trails-api-roles-management
…-management

# Conflicts:
#	audit-trail-move/sources/locking.move
#	audit-trails-move/sources/audit_trails.move
…anagement

Feat/audit trails api roles management
Comment on lines 31 to 38
// TODO: Is this needed? What is a setup capability?
//
// /// Create a setup capability for trail initialization
// public fun new_setup_cap(ctx: &mut TxContext): Capability {
// Capability {
// id: object::new(ctx),
// }
// }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

itsyaasir and others added 3 commits January 5, 2026 09:59
Also split of the role and capability management from the AT main module to allow reuse with other products.
…extended

# Conflicts:
#	audit-trail-move/sources/audit_trail.move
#	audit-trail-move/sources/capability.move
#	audit-trail-move/tests/capability_tests.move
#	audit-trail-move/tests/create_audit_trail_tests.move
#	audit-trail-move/tests/role_tests.move
#	audit-trail-move/tests/test_utils.move
chrisgitiota and others added 17 commits January 5, 2026 15:15
- Changed capability permission checks in `has_capability_permission` and `destroy_capability` functions to use `cap.trail_id()` instead of `cap.id()`.
- Improved test cases for capability creation, revocation, and metadata updates, ensuring proper permission handling and error scenarios.
- Added new tests for locking configurations and metadata management, enhancing overall test coverage for the audit trail functionality.
- Reformatted function calls in locking and role tests for better readability by aligning parameters across multiple lines.
- Enhanced clarity in test cases related to locking configurations and role permissions, ensuring easier maintenance and understanding of the test logic.
- Fixed typos in comments related to the `Permission` enum and `admin_permissions` function for clarity.
- Enhanced documentation to better reflect the intended roles and permissions within the audit trail system.
…ns to use non-optional name field; adjust tests for consistency
chore: function refactor, adding of emitting events & improving test coverage
…extended

# Conflicts:
#	audit-trail-move/sources/audit_trail.move
#	audit-trail-move/tests/capability_tests.move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants