Skip to content

chore: refactor directory structure#53

Merged
itsyaasir merged 6 commits intodevelopfrom
chore/refactor-dir
Jun 20, 2025
Merged

chore: refactor directory structure#53
itsyaasir merged 6 commits intodevelopfrom
chore/refactor-dir

Conversation

@itsyaasir
Copy link
Contributor

Description of change

Links to any relevant issues

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

… functionality

- Updated the `.gitignore` to include `.idea` directory.
- Refactored imports in example files to use the new `notarization::core::types` module for `State` and `TimeLock`.
- Introduced new transaction types for creating, destroying, transferring, and updating notarizations.
- Added comprehensive type definitions for notarization events, metadata, and state management.
- Improved the handling of time locks and state transitions within the notarization process.
- Enhanced documentation and examples for better clarity on usage and functionality.
@itsyaasir itsyaasir self-assigned this Jun 13, 2025
@itsyaasir itsyaasir changed the base branch from main to develop June 13, 2025 17:17
@itsyaasir itsyaasir changed the base branch from develop to feat/add-docs June 13, 2025 17:22
@chrisgitiota
Copy link
Contributor

Looks good!

How about moving notarization-rs/src/core/builder.rs into the notarization-rs/src/client folder?

@itsyaasir itsyaasir changed the base branch from feat/add-docs to develop June 17, 2025 05:38
@itsyaasir itsyaasir changed the base branch from develop to feat/add-docs June 17, 2025 05:39
@itsyaasir
Copy link
Contributor Author

Looks good!

How about moving notarization-rs/src/core/builder.rs into the notarization-rs/src/client folder?

I wanted to ask if there is reason for this change ?

- Consolidated import statements for `iota_interaction::rpc_types` and `iota_interaction::base_types` to improve code clarity and organization.
@itsyaasir itsyaasir requested a review from chrisgitiota June 17, 2025 07:39
@itsyaasir itsyaasir changed the base branch from feat/add-docs to develop June 17, 2025 07:40
@itsyaasir itsyaasir merged commit 854bbfc into develop Jun 20, 2025
5 checks passed
@itsyaasir itsyaasir deleted the chore/refactor-dir branch June 20, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants