Skip to content

Add cargo deny, lints and test workflows#36

Merged
samuel-rufi merged 10 commits intomainfrom
ci
Feb 6, 2025
Merged

Add cargo deny, lints and test workflows#36
samuel-rufi merged 10 commits intomainfrom
ci

Conversation

@samuel-rufi
Copy link
Contributor

@samuel-rufi samuel-rufi commented Feb 3, 2025

Description

Adds cargo deny, lints and test workflows

Relevant issues:

Fixes #31

@samuel-rufi samuel-rufi self-assigned this Feb 3, 2025
Copy link
Collaborator

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't the CI running? It might make sense to just use ubuntu-latest for this repo.

@samuel-rufi
Copy link
Contributor Author

Hey @kodemartin, I was wondering the same thing and I think this would need to be investigated with devops (also considering if there is anything we need to add to the repo). Replacing it with ubuntu-latest makes it work. So I assume there is something not fully configured currently with this repo. Anyways, I also think it's fine to use ubuntu-latest here and just go with that now.

Copy link
Collaborator

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🍒

Copy link
Collaborator

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm...I rushed into it. deny is failing...could please seek to revise the rules or find a solution?

@samuel-rufi samuel-rufi requested a review from tomxey February 5, 2025 13:03
Copy link

@tomxey tomxey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ⛄️

@samuel-rufi samuel-rufi merged commit 557bfa3 into main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add clippy, fmt, deny CI workflow

3 participants