Conversation
|
Maybe we need to squash the commits, some of the naming are not very proper |
sure. will do |
bas-io
force-pushed
the
fix/cluster-tests
branch
from
0f8d4de to
7e1e2b1
Compare
| e.testAccounts() | ||
| } | ||
|
|
||
| func TestBasicAccountsNLow(t *testing.T) { |
There was a problem hiding this comment.
May I ask the reason to remove this one?
There was a problem hiding this comment.
I noticed that with previous implementation there was significant amound of overlap in what cluster tests are testing. Simple deposit/withdrawal was tested multiple times with all kinds of configurations (1 node, 2 nodes, 3 nodes and so on). I tried to simplify it so that tests in overall run faster, increase granularity of tests and give descriptive names.
For this particular case I renamed it to testOffLedgerDepositWithdrawTransfer so that it's more descriptive and I only test default cluster configuration. I think I raised this question on a meeting before questioning the purpose of running some test for N=1, N=2, etc, I mean if we just test default (4 nodes) configuration it should cover all cases
2 participants
No description provided.