refactor: use t.TempDir() instead of os.MkdirTemp#4575
Merged
CoderZhi merged 2 commits intoiotexproject:masterfrom Mar 15, 2025
Merged
refactor: use t.TempDir() instead of os.MkdirTemp#4575CoderZhi merged 2 commits intoiotexproject:masterfrom
CoderZhi merged 2 commits intoiotexproject:masterfrom
Conversation
Signed-off-by: yuhangcangqian <cuibuwei@qq.com>
There was a problem hiding this comment.
PR Overview
This pull request refactors the test files to use t.TempDir() instead of os.MkdirTemp(), thereby simplifying temporary directory creation and cleanup in tests.
- Replaced os.MkdirTemp with t.TempDir() in db_pebble_test.go for TestPebbleDB, TestPebbleDB_Filter, and TestPebbleDB_Foreach.
- Removed custom cleanup calls using testutil.CleanupPath as t.TempDir() automatically cleans up.
Reviewed Changes
| File | Description |
|---|---|
| db/db_pebble_test.go | Refactored temporary directory creation in tests |
| server/itx/server_test.go | Updated temporary directory creation for action store |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
envestcc
approved these changes
Mar 11, 2025
CoderZhi
approved these changes
Mar 15, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
TempDir returns a temporary directory for the test to use.The directory is automatically removed when the test and
all its subtests complete. More info https://pkg.go.dev/testing#B.TempDir
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: