Closed
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a common module for debugging data race issues by wrapping the standard RWMutex with logging functionality.
- Added a new RWMutex implementation with logging support
- Provided an option to use a custom logger
- Included a basic test file for verifying the mutex functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/sync/rwmutex.go | Implements the RWMutex wrapper with logging of lock/unlock events |
| pkg/sync/rwmutex_test.go | Adds tests for basic sequential operations of the RWMutex |
Comments suppressed due to low confidence (1)
pkg/sync/rwmutex_test.go:9
- The tests currently only cover sequential locking and unlocking. Adding tests for concurrent access would help validate the thread-safety of RWMutex.
func TestRWMutex(t *testing.T) {
| // NewRWMutex creates a new RWMutex with the provided options. | ||
| func NewRWMutex(opts ...RWMutexOption) *RWMutex { | ||
| rw := &RWMutex{ | ||
| uuid: time.Now().Unix(), |
There was a problem hiding this comment.
Using time.Now().Unix() for uuid may lead to collisions if multiple mutex instances are created within the same second. Consider using time.Now().UnixNano() for higher resolution.
Suggested change
| uuid: time.Now().Unix(), | |
| uuid: time.Now().UnixNano(), |
CoderZhi
reviewed
Mar 15, 2025
| } | ||
|
|
||
| func (lm *RWMutex) logger() *zap.Logger { | ||
| return lm.loggerFn().WithOptions(zap.AddCaller(), zap.AddCallerSkip(1)).With(zap.Int64("uuid", lm.uuid)) |
Collaborator
There was a problem hiding this comment.
could we keep the instance of lm.loggerFn()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce common module for easy debugging data race issues
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: