Open
Conversation
|
envestcc
reviewed
Mar 21, 2025
| version: version.ProtocolVersion, | ||
| height: 0, | ||
| timestamp: time.Unix(genesis.Timestamp(), 0), | ||
| timestamp: timestamp, |
Member
There was a problem hiding this comment.
Does this solve the issue of block.Hash() not being equal to genesis.Hash() when the block height equals 0?
Collaborator
Author
There was a problem hiding this comment.
sadly, no...
with current implementation, block(0) shouldn't return a block, but throw an error.
we made a mistake here: block(0).hash() == genesis.Hash(). if we were able to redesign the blockchain, block(0).prevHash == genesis.Hash() and block(0) is the very first block instead of a virtual block.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Need to further clean up
filedao, but leave it for now.Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: