fix: use importedAlias.Name instead of args[0] in alias import#4799
Merged
envestcc merged 2 commits intoiotexproject:masterfrom Mar 17, 2026
Merged
fix: use importedAlias.Name instead of args[0] in alias import#4799envestcc merged 2 commits intoiotexproject:masterfrom
envestcc merged 2 commits intoiotexproject:masterfrom
Conversation
SetAlias was called with args[0] (the file path argument) instead of importedAlias.Name, causing all imported aliases to be set to the same name (the import file path). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
CoderZhi
approved these changes
Mar 16, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
ioctl/newcmd/alias/aliasimport.go,SetAliaswas called withargs[0](the file path argument) instead ofimportedAlias.Name, causing all imported aliases to be set to the import file path name instead of their actual alias names.Fix
Replace
args[0]withimportedAlias.Name.