Skip to content

fix: update windows binary regex#27

Merged
SgtPooki merged 2 commits intomainfrom
fix-windows-regex
May 23, 2025
Merged

fix: update windows binary regex#27
SgtPooki merged 2 commits intomainfrom
fix-windows-regex

Conversation

@lidel
Copy link
Member

@lidel lidel commented May 23, 2025

Windows link did not update in README on release, I had to update manually:

I think this is because regex is very crude and assumes windows name to be camel case, while it is now lowercase.

Had to update manually:
- ipfs/ipfs-desktop@baced38

I think this is because regex is very crude and assumes windows name to be camel case, while it is now lowercase
@lidel lidel requested a review from SgtPooki May 23, 2025 02:34
@lidel
Copy link
Member Author

lidel commented May 23, 2025

@SgtPooki I think semantic release is broken in main branch and here, mind taking a look?

https://github.com/ipfs-shipyard/release-please-ipfs-plugin/actions/runs/15201004450/job/42755012881?pr=27#step:1:47

@SgtPooki SgtPooki merged commit 7a06a4e into main May 23, 2025
7 checks passed
@SgtPooki
Copy link
Member

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SgtPooki SgtPooki deleted the fix-windows-regex branch May 29, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants