Conversation
Fixes inotify errors found in #7. The build process now only has to watch the src dir rather than the whole project. Brings external img refs inline so all the things are deployed to ipfs. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
victorb
reviewed
Jul 17, 2018
| <header class='pv3 ph2 ph3-l bg-navy cf'> | ||
| <a href="https://multiformats.io/" title='ipfs.io'> | ||
| <img src="https://ipfs.io/images/ipfs-logo.svg" class='v-mid' style='height:50px' /> | ||
| <a href="https://ipfs.io/ipns/multiformats.io/" title='ipfs.io'> |
Member
There was a problem hiding this comment.
Hm, is there a specific reason for linking to not the canonical version? IPNS tends to be a bit slower than just using DNS + IPFS hashes
Member
Author
There was a problem hiding this comment.
I did not know that... I'll change them back.
|
@olizilla can be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inotify errors found in #7. The build process now only has to
watch the src dir rather than the whole project.
Brings external img refs inline so all the things are deployed to ipfs.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io