Skip to content

added support for newly added Query.SeekPrefix #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added support for newly added Query.SeekPrefix #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion datastore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,11 @@ func (t *txn) Query(q dsq.Query) (dsq.Results, error) {
txn := t.txn

it := txn.NewIterator(opt)
it.Seek(prefix)
if len(q.SeekPrefix) > 0 {
it.Seek([]byte(q.SeekPrefix))
} else {
it.Seek(prefix)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably seek to the "later" prefix (in case the seek prefix comes before the Prefix).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this all depends on the ordering. If we've reversed the order, we'd want to seek to the "earlier" prefix.

Speaking of ordering, we technically need to apply the "seek" prefix after the order. Badger internally handles ordering by key (ascending or descending) but we have to apply all other orderings (e.g., by value) after the fact.

So, if we aren't applying any additional orders len(order) == 0, we're all good. Otherwise, we should either return a not supported error or apply a naive seek after ordering.

if q.Offset > 0 {
for j := 0; j < q.Offset; j++ {
it.Next()
Expand Down